fix: remove GCM module #1091
fix: remove GCM module #1091
Conversation
There was a problem hiding this comment.
Looks good, can you add the breaking change entry to the changelog?
The process of updating the changelog may be different in this repo, but I want to make sure we don't forget it.
According to semver this would be a major version increment for this SDK. What is the current versioning system for this repo?
|
Updated! Yep, this would be a 1.27.0 release |
|
I added the PR link and removed the version from the changelog as the version doesn’t exist yet. I wonder why the CI fails, can’t see that well on mobile. |
|
Oh yeah not sure about CI. We should leave in the version though because I will release it after this PR is merged in. |
|
I assume we should move from Travis CI to GH Actions at some point, the failing CI does not seem related to any tests. |
|
Yeah, I am all for moving over. |
|
@Jawnnypoo could you take a look and resolve the conflicts? we would merge this to prepare for a 2.0.0 release; if you merge master into this branch, the CI already works Is this PR a breaking change? Or is GCM not supported anymore anyway and therefore we are just removing it |
|
@L3K0V Is this good to merge in your opinion? (I can't select your name for review request yet) |
Codecov Report
@@ Coverage Diff @@
## master #1091 +/- ##
=========================================
Coverage 65.06% 65.06%
Complexity 2208 2208
=========================================
Files 122 122
Lines 9463 9463
Branches 1317 1317
=========================================
Hits 6157 6157
Misses 2799 2799
Partials 507 507 Continue to review full report at Codecov.
|
|
LGTM |
# [2.0.0](1.22.0...2.0.0) (2021-10-10) ### Bug Fixes * remove GCM module ([parse-community#1091](https://github.com/mtrezza/Parse-SDK-Android/issues/1091)) ([aa16bcf](aa16bcf)) * upgrade Facebook SDK ([parse-community#1105](https://github.com/mtrezza/Parse-SDK-Android/issues/1105)) ([6f4bdb0](6f4bdb0)) ### Features * update all dependencies and modernize the source base ([parse-community#1095](https://github.com/mtrezza/Parse-SDK-Android/issues/1095)) ([a977d11](a977d11)) ### BREAKING CHANGES * CHANGE Support for Google Cloud Messaging (GCM) is removed, use Firebase Cloud Messaging instead. See the [Google developer documentation](https://developers.google.com/cloud-messaging/faq) for more details and migration assistance. ([aa16bcf](aa16bcf))
No longer supported